search

akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 516 forks source link

Wrong formating at WYSIWYG attribute #6101

Closed krafas closed 7 years ago

krafas commented 7 years ago

After upgrade to the newest 1.7 version we have problem with text formating at wysiwyg editor. The same issue exists in demo (http://demo.akeneo.com/#url=/enrich/product/1101?dataLocale=en_US)

When formating list no bullets and no numbers are shown: image

But the code have correct styling: image

pierallard commented 7 years ago

Hi !

It's a bug introduced by this: https://github.com/akeneo/pim-community-dev/blob/master/src/Pim/Bundle/UIBundle/Resources/public/less/base/general.less#L53

We have to override this rule in the wysiwyg context, in this file https://github.com/akeneo/pim-community-dev/blob/master/src/Pim/Bundle/UIBundle/Resources/public/less/lib/summernote.less to match original browser rules https://www.w3schools.com/cssref/css_default_values.asp

by adding something like this...

.note-editable ol { list-style-type: decimal; margin-left: 1em; }
.note-editable ol > li { list-style-type: decimal }

Feel free to do a pull request, it's an easy pick :)

pierallard commented 7 years ago

Fixed! Thanks a lot @xElysioN !