akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 514 forks source link

Q: Migrate to 1.7 - Bootstrap CSS classes #6224

Closed Hocdoc closed 7 years ago

Hocdoc commented 7 years ago

I'm asking a Question

We are migrating our PIM from 1.6 to 1.7.

We have many custom pages which use the Bootstrap 2. I've found the Akeneo Styleguide, but it's still unclear for me how we can migrate our pages to 1.7:

pierallard commented 7 years ago

Hi @Hocdoc !

You're right, in 1.7, we removed 90% of the bootsrap v2.3. We implemented a BEM methodology in this version.

I will answer your questions:

My turn ; can you give me a list of all the blocks you need ? It's always interesting to know what integrators added. If your modules are interesting and you think it can re-usable, don't hesitate to create a pull request on PIM + doc to add it :)

Pierre

Hocdoc commented 7 years ago

Thanks for your helpful feedback.

I see the advantages of the BEM methodology and like the small CSS files ;-) but it comes with a price. Maybe it would be better to use a popular, tested CSS framework like Bootstrap that most developer know as a base and than add your own BAM CSS classes on top of it.

Unfortunately adding Bootstrap 2 directly produce too many conflicts with the Akeneo CSS, so we manually adapt our old CSS classes. This was the most time consuming part of our Akeneo 1.6->1.7 migration.

On the other side our custom pages share now much more the look&feel from the Akeneo pages. :-)

pierallard commented 7 years ago

@Hocdoc we discuss a long time to the strategy to adapt in this case. The fact is bootstrap is very famous framework but had disadvantages:

Best regards ;)