search

akeneo / pim-community-dev

[Community Development Repository] The open source Product Information Management (PIM)
http://www.akeneo.com
Other
954 stars 514 forks source link

Cannot merge even with a green build #9524

Closed damien-carcel closed 5 years ago

damien-carcel commented 5 years ago

This PR https://github.com/akeneo/pim-community-dev/pull/9477 build was successfull (and merged with admin rights), but the required check circleci stayed as not run, preventing the merge. The green checks in the PR correspond to the different steps of the job (unit tests, integration tests, behats...), but not to the whole build (which is the one used for branch protection).

As a comparison, I setup CircleCi on a project of mine and don't have this behavior: instead of seeing all the steps, I only saw the build, and in the settings, when protecting a branch, instead of seeing all the steps, I only see my 2 workflows ("pull_request" and "weekly"). The main difference I have is that I enabled the GitHub checks. Could be the cause of this behavior difference.

damien-carcel commented 5 years ago

This is not an issue anymore now that the branches are protected with the legacy_behat (last job to be run in the workflow). Closing.