akeneo / transporteo

Migration Tool for Akeneo PIM from 1.7 to 2.0
Other
8 stars 7 forks source link

MIG-36-variant-group #108

Closed LaurentPetard closed 6 years ago

LaurentPetard commented 7 years ago

Migration of the variant groups. The main difficulty was to regroup family and variant groups axes to be able to create the family variants.

ahocquard commented 7 years ago

You should avoid to use too much private functions that are replacing services. It breaks SRP too often and it's hard to understand/test.

You should split it in this PR, some things were hard to understand.

Two other concerns that could be fix in another PR:

LaurentPetard commented 7 years ago

I will refactor DestinationPim and SourcePim as services in a side PR, because it changes the IVB migration too, and this PR is big enough.