akeneo / transporteo

Migration Tool for Akeneo PIM from 1.7 to 2.0
Other
8 stars 7 forks source link

Fix source PIM version check to allow ^1.7 or ~1.7 or similar #146

Open bpresles opened 6 years ago

bpresles commented 6 years ago

The source Pim version check verify that the version string on composer.json container the "1.7." string.

But when the version string is like "^1.7", which means ">= 1.7 < 2.0" and so is perfectly valid, because it confirms that the source pim is a 1.7.x version, the check doesn't work because it doesn't contain a 1.7.* version string.

This check should allow ^1.7 or ~1.7 as source pim version, that's why it should only check for "1.7"

Related issue: https://github.com/akeneo/transporteo/issues/145

Definition Of Done

Q A
Added Specs Todo
Review and 2 GTM Todo
Micro Demo to the PO (Story only) Todo

Todo: Pending / Work in progress OK: Done / Validated -: Not needed