search

akermu / emacs-libvterm

Emacs libvterm integration
GNU General Public License v3.0
1.69k stars 135 forks source link

Regression: vterm buffers mysteriously missing from Workspaces #550

Open fosskers opened 2 years ago

fosskers commented 2 years ago

I just completed a git bisect, and it seems that commit https://github.com/akermu/emacs-libvterm/commit/74e864a475801147e6c58cd598ffd7625bcf7cf9 has the ill effect downstream of making *vterm* buffers invisible to the workspace that they were opened in. Previously this issue did not occur, and it was possible to, for instance, programmatically detect all open *vterm* buffers and close them. They also showed in the list of "workspace buffers".

Note that a normal "show all buffers" command does list them; they're only somehow invisible to their workspace.

Any thoughts? Thank you kindly.

Sbozzolo commented 2 years ago

What is a workspace in this context?

fosskers commented 2 years ago

Workspaces as provided by https://github.com/Bad-ptr/persp-mode.el and configured by Doom Emacs https://github.com/hlissner/doom-emacs/blob/develop/modules/ui/workspaces/config.el

fosskers commented 2 years ago

The change made in the linked commit above apparently has this effect:

Displaying buffers before they are initialized (rather than after) breaks custom display-buffer-alist rules that depend on buffer state to decide what to do.

(Quoted from someone who helped me debug this originally)