search

akermu / emacs-libvterm

Emacs libvterm integration
GNU General Public License v3.0
1.72k stars 137 forks source link

unable to locally remap default face #696

Open nehrbash opened 10 months ago

nehrbash commented 10 months ago

before commit e96c53f I was able to make vterm a slightly different color by adding a hook that used face-remap-add-relative

(face-remap-add-relative
                   'default
                   :background "#281d12")

Now I don't seem able to override the default face nor is there a vterm background face to customize.

linwaytin commented 10 months ago

I have the same issue.

mina86 commented 3 months ago

This is also what auto-dim-other-buffers uses (together with :filtered face predicate). There’s a feature request to support vterm in adob but it’s not possible without this feature.

getong commented 3 months ago

vterm is great, but with auto-dim-other-buffers.el, it does not work well.

lrustand commented 2 months ago

I tried using the old version of vterm-get-color from the commit mentioned above, and it worked as it should. I have no idea why they would introduce the new function definition, since I have not noticed anything at all that is not working as it should with the old one. I did not have to change anything in the C code, I only changed back the one elisp function.

linwaytin commented 2 months ago

@lrustand Thanks a lot. The workaround you posted works.

I hope they can bring the previous behavior back.