Hostname issue in bash

[Ergus]

Hi:

The hostname command is not part of bash by default. It seems like some distros deliver the variable $HOSTNAME instead. For those distros (like mine Arch Linux) it may be better to change

vterm_prompt_end(){
    vterm_printf "51;A$(whoami)@${HOSTNAME}:$(pwd)"
}

Or a more elaborated alternative that attempts to use the right version like:

[[ -n $HOSTNAMEE ]] && echo $HOSTNAME || (command -v hostname > /dev/null && hostname)

or similar (I am sure it may be a much better alternative)

[Sbozzolo]

Interesting, I always assumed that hostname was available everywhere. It is not a bash-builtin, but a binary. I guess we could change it to uname -n, which should be POSIX.

I personally find $HOSTNAME not very robust. It is a variable and as such users/admins could change it.

[Ergus]

Also a nice solution!

[Sbozzolo]

If you open a PR, I'll merge it :)

Thanks in advance!

[Ergus]

Hi @Sbozzolo :

I made the modification for this issue a long time ago, but I never merged it. The change is very simple, and I can open a merge request. However, There is a detail that still worries me. And it is the line:

PROMPT_COMMAND="${PROMPT_COMMAND:+$PROMPT_COMMAND; }"'echo -ne "\033]0;${HOSTNAME}:${PWD}\007"'

It still uses HOSTNAME the variable. And I am not sure if you want to change it as well because you said.

I personally find $HOSTNAME not very robust. It is a variable and as such users/admins could change it.

I'll open a pull request when this detail will ve solved.

[Sbozzolo]

Could you use uname -n instead?