akermu / emacs-libvterm

Emacs libvterm integration
GNU General Public License v3.0
1.72k stars 137 forks source link

Compilation fails on Mac OS when libtool is not named "glibtool" #716

Open rome-user opened 7 months ago

rome-user commented 7 months ago

Hello,

I am currently using Nix as my package manager on a new Mac. The libtool package provides libtool binary rather than glibtool. This causes the libvterm module to fail compilation. See logs below

-- System libvterm not found: libvterm will be downloaded and compiled as part of the build process
-- Configuring done (0.3s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/*/.emacs.d/straight/build/vterm/build
[  8%] Performing update step for 'libvterm'
[ 16%] No patch step for 'libvterm'
[ 25%] No configure step for 'libvterm'
[ 33%] Performing build step for 'libvterm'
CC src/encoding.c
make[3]: glibtool: No such file or directory
make[3]: *** [src/encoding.lo] Error 1
make[2]: *** [libvterm-prefix/src/libvterm-stamp/libvterm-build] Error 2
make[1]: *** [CMakeFiles/libvterm.dir/all] Error 2
make: *** [all] Error 2

However, libtool exists and is accessible from shell

% which libtool
/Users/*/.nix-profile/bin/libtool

I have considered alternatives, such as using Nix to manage Emacs packages, but the emacs-overlay does not support Unicode characters in init.el. So installing the vterm package from Nix is not an option for me

rome-user commented 7 months ago

On further investigation, I found that the problem lies outside of this package's control. The issue is here: https://github.com/Sbozzolo/libvterm-mirror/blob/libvterm/Makefile#L1-L5