Add open fun delegateBaseContext(context: Context) method to LocalizationActivity. This method should allow a custom activity to wrap localized base context with other API e.g. ViewPump. This should fix #116
I have locally tested instrument tests on Android 4.4 (sdk 19), Android 5 (sdk 21) and Android 9 (sdk 28) devices. Please run your CI after merging this PR to fix-web-view-crashing branch since the CI only runs when PR to master.
akexorcist
commented
2 years ago
API Changes
open fun delegateBaseContext(context: Context)method toLocalizationActivity. This method should allow a custom activity to wrap localized base context with other API e.g. ViewPump. This should fix #116delegateBaseContext(context: Context)returnslocalizationDelegate.attachBaseContext(context).applyOverrideConfiguration, IMO, is no longer needed as its solution is recommended in https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeCustomAttachBaseContextActivity.javaBREAKING CHANGES
targetSdkVersionfrom 30 to 31appcompatversion to1.4.0Note
I have locally tested instrument tests on Android 4.4 (sdk 19), Android 5 (sdk 21) and Android 9 (sdk 28) devices. Please run your CI after merging this PR to
fix-web-view-crashingbranch since the CI only runs when PR tomaster.