search

akezeke / spotyxbmc2

spotyXBMC is a fork of XBMC with spotify support
Other
133 stars 29 forks source link

Sensible merging with upstream #35

Closed neoflex closed 12 years ago

neoflex commented 12 years ago

I finally took the time to try to resolve the merging issues to keep spotyXBMC2 up to date with master. It seems to be working but I think it should be tested by others before integrating. There has been some changes on CSong, CAlbum, and others classes which had some consequences for spotify files.

akezeke commented 12 years ago

Great work! Compiling now!

akezeke commented 12 years ago

Works well on my system! Thanks for the merge, have you looked at newest version of libspotify?

neoflex commented 12 years ago

Great to hear that it works. No, didn't look the libspotify update. I'll let you this :p

akezeke commented 12 years ago

Hi,

I guess we should stick with the version we use now then!

2012/5/11 Valentin Grouès < reply@reply.github.com

Had a look to libspotify 11.1.60. It seems that they removed radio support :-/ Personally I don't really used them but I guess it would be a bad surprise for some people if we upgrade now.

Reply to this email directly or view it on GitHub: https://github.com/akezeke/spotyxbmc2/pull/35#issuecomment-5656792

neoflex commented 12 years ago

Yep, until they block old versions ;) If you have a little bit of time, I am kind of stuck with the next merge with upstream. They merged the AudioEngine branch and even if it still compiles with spotify, it crashes as soon as I try to play a spotify song.