search

akezeke / spotyxbmc2

spotyXBMC is a fork of XBMC with spotify support
Other
133 stars 29 forks source link

read appkey at runtime #53

Closed escoand closed 11 years ago

escoand commented 11 years ago

add functionality to read appkey at runtime so it could be published as binary and there is no need to compile it

akezeke commented 11 years ago

Hi,

Just to let you know... the reason why you cant share a precompiled XBMC with spotyxbmc is not due to the api-key. The key is no problem to share in a precompiled application (read spotify api license).

The problem is that you violates XBMC license. It says that you cant have a precompiled version of XBMC that contains closed source parts (like spotify API).

The solution for this is rather to have the spotify api loaded in realtime and not just the key. It is possible of course but I dont have the time to do it and I have no problems compiling myself.

regards David

escoand commented 11 years ago

What has to be extracted and separated? Can you give a list (of files/classes/functions)? The library itself is separated. In my opinion the API is only the part to interact with that library - or am I wrong? Do we need a separated library to load the spotify library?

akezeke commented 11 years ago

What has to be done is that the library (libspotify.dll in windows) cant be static linked. It has to be dynamically loaded when xbmc is running.

bdunogier commented 11 years ago

@akezeke, could you enlighten us on the status of binary addons in XBMC ? Is it somehow part of the roadmap ? And if yes, is what's planned sufficient for you to distribute the spotify part as a distinct addon ?

I don't really see much going on in this regards, but the XBMC community can be hard to follow...

escoand commented 11 years ago

take a look at the other pull request, it is adding dynamic library linking