search

akgold / do4ds

A book on DevOps for Data Scientists with CRC Press.
https://do4ds.com
Other
131 stars 28 forks source link

1-3 typos and notes #106

Closed jonthegeek closed 1 year ago

jonthegeek commented 1 year ago

Lines 47-53: I don't like this wording, but I don't have a strong suggestion of how to fix it. You have things to say, you just don't have a LOT to say. It gave me a feeling of "then why am I reading this?" which I don't think was what you were aiming at!

Line 55: I threw in a couple "(DEFINITION)"s for you to fill in. It would be good to clearly differentiate business logic vs app logic early in this discussion to make sure the reader is following your... logic 🙃

I changed at least one instance of "shiny" to "Shiny" to match previous instances, but generally choose one and stick with it. CRAN had me change Shiny to 'shiny' in a recent package, FWIW.

Lines 138+: When you redefine the app, it'd probably help to just show the change in the server logic, since the ui doesn't change.

Line 166: When you define the filter_data() function, probably include the c("Adelie", "Chinstrap", "Gentoo") default. I think. It feels less confusing if the plumber implementation is exactly the function from shiny.

Line 282: I suggest sticking with wildlife. Hospital examples can remind people of friends/family dying, etc.

Line 312: Thought trails off/isn't completed.

General thought: Maybe you don't want to recommend this, but I've found googlesheets4 to be a great middleground between flat file and database. It gives me a simple UI to add data, allows me to write, and has good-enough availability/concurrency for simple use cases.

Is there a good free option for experimenting with Plumber, equivalent to free-tier shinyapps.io? I think technically (maybe) you can deploy Plumber APIs to shinyapps, but it's "off label." If you know of something, suggesting it could be helpful for people who are trying to experiment with the suggestions in the book (and I'm going to sort that out right now 'cuz I'd love to API-ize some things for R4DS apps, but I don't really have the option right now to put them onto a paid service).

jonthegeek commented 1 year ago

Oh, and I love the new Portfolio Exercise sections!

akgold commented 1 year ago

Thanks Jon, these are great. Will respond to the comments in another PR