search

akgulebubekir / Maui.DataGrid

DataGrid component for Maui
MIT License
261 stars 54 forks source link

Silence StyleCop warnings #191

Closed symbiogenesis closed 2 months ago

symbiogenesis commented 5 months ago

I recently turned on lots of warnings to help ensure readability, code quality, and consistency. I fixed the uncontroversial warnings.

In this PR, the controversial warnings from before I am silencing, which should preserve most of the original stylistic feeling.

These are: SA1101, SA1124, and SA1309

The general concept behind SA1101 and SA1309, as described, is to make it explicit that you are calling a method of a particular instance, and that you are covertly passing "this" to non-static methods. It also allows better IntelliSense.

SA1124 recommends not using regions and provides an explanation for why. Regardless, the other element ordering rules which are being followed will help ensure consistent member ordering and readability, with or without regions.

symbiogenesis commented 5 months ago

@akgulebubekir your call whether to merge this, or follow another approach.