akhanss / datapath

Automatically exported from code.google.com/p/datapath
0 stars 0 forks source link

Tester incorrectly reports that TPCH Query 2 fails #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run the tester on TPCH-Q2.pgy (assuming TPC-H 1G data is loaded already)
2. View the results in test_results.sqlite

What is the expected output? What do you see instead?
You should see that it passed.
It says that it fails, however.

This is because some of the comments in the supplier relation contain spaces as 
their first character, and currently the checker discards leading whitespace 
when parsing the data (this was done to allow one to nicely structure 
multi-column expected results in the source file).

The format of the expected results in the source file needs to be changed such 
that strings are surrounded in quotes.

Original issue reported on code.google.com by Luminaire1202 on 19 Jun 2012 at 10:06

GoogleCodeExporter commented 9 years ago
Started on this.

It appears that PostgresSQL may make this easy, assuming its COPY operation 
works as I believe it does when you set the format to CSV.

Original comment by Luminaire1202 on 19 Jun 2012 at 10:10

GoogleCodeExporter commented 9 years ago
It appears that the best way to do this would be to change the tester to ignore 
trailing spaces instead.

Original comment by Luminaire1202 on 19 Jun 2012 at 10:20

GoogleCodeExporter commented 9 years ago
I apparently can't spell (changed title)

Original comment by Luminaire1202 on 20 Jun 2012 at 3:05

GoogleCodeExporter commented 9 years ago
Changed the tester's parsing to (hopefully) work using proper CSV-style 
formatting.

Original comment by Luminaire1202 on 20 Jun 2012 at 3:06