search

akhanubis / anu_twitch_chat_overlay

Issues tracker for Twitch Chat Overlay browser extension
7 stars 1 forks source link

feat: Join chat room when/if necessary #58

Closed louis-pre closed 4 months ago

louis-pre commented 5 months ago

Context

Table below shows when ATCO tries to join the chat room by opening and closing the chat sidebar: iframe chat Native chat
Stream Yes No
VOD No No

However, except if I'm missing something, the only time we need to do this is if we are using the native chat during a stream as VODs don't require joining a chat room and the iframe chat joins the chat room automatically.

Changes

New behavior: iframe chat Native chat
Stream No Yes
VOD No No

This should improve the experience for both use-cases impacted.

The only risk introduced by this PR should be for the use-case Stream + iframe chat if I somehow missed another reason for opening/closing the chat sidebar apart from trying to join the chat room.

akhanubis commented 5 months ago

Ty! I'll look into it sometime during the next few days

louis-pre commented 5 months ago

Sounds good, thank you! I tried to follow existing conventions but some stuff was harder for me to guess based on existing code alone. Feedback is very welcome, it would help me make my other work compliant before opening new PRs 👍

akhanubis commented 4 months ago

Didnt have time to review it in detail but it seems to be working fine! Merged in 1.0.3