search

akhenry / openmct-yamcs

Open MCT YAMCS plugin
14 stars 9 forks source link

Imagery overlay toggle doesn't track state properly #374

Closed charlesh88 closed 1 year ago

charlesh88 commented 1 year ago

Summary

Imagery overlay checkbox doesn't set its state properly. It will display checked even though the overlay isn't shown.

image

Expected vs Current Behavior

Short term: Fix the checkbox so it accurately reflects the state. Longer term: We need to determine what the right behavior should be here around whether the grid persists or not. There are potentially a lot of options around what we tie the persistence of the visibility of the grid to:

  1. To the end point: persist the setting in session or per machine. So, turn on the grid for the nav cam, and it's pretty much always on for that camera, even when navving to different instances of that view, like main view and that image in a layout.
  2. To the view instance: turn on the grid in an Image's main view, and the setting persists, even when navving around and coming back. Same goes, but separately, for that image when placed in a layout.
  3. To nothing, it's transient: it could work like plot cursor guides - turn 'em on when you're in a plot, but the setting doesn't persist at all. This is what we'll get with the short term fix as outlined above.

We should socialize this with users for feedback. That said, I find option 3 the least desirable. That might work Ok now with a single layer, but when a user might be managing visibility of several layers, having to re-enable even 3 layers every time would not be good.

Impact Check List

Steps to Reproduce

  1. Add an Imagery view to a layout.
  2. Enable the grid overlay.
  3. Navigate to another object, then back to the layout.
  4. Observe: the grid layer checkbox will be checked, but the grid isn't showing.

Environment

Additional Information

charlesh88 commented 1 year ago

Argh, wrong repo.