[Fault MGMT] Support trigger and current values other than doubles - Githubissues

akhenry / openmct-yamcs

Open MCT YAMCS plugin

14 stars 9 forks source link

[Fault MGMT] Support trigger and current values other than doubles #379

Closed michaelrogers closed 11 months ago

michaelrogers commented 12 months ago

Closes #380

Describe your changes:

Used the getValue util to extract the value for currentValue and triggerValue instead of being hardcoded to doubleValue.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

[ ] Changes address original issue?
[ ] Tests included and/or updated with changes?
[x] Command line build passes?
[ ] Has this been smoke tested?
[ ] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

[ ] Changes appear to address issue?
[ ] Reviewer has tested changes by following the provided instructions?
[ ] Changes appear not to be breaking changes?
[ ] Appropriate automated tests included?
[ ] Code style and in-line documentation are appropriate?
[ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
[ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)