Fix realtime limits - Githubissues

shefalijoshi commented 1 year ago

Closes https://github.com/nasa/openmct/pull/7151 Closes #439

Describe your changes:

Add logic to clear limits in yamcs before running each limits test. Add a new test to check that no network requests occur when redrawing limits due to resizing

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

[x] Changes address original issue?
[x] Tests included and/or updated with changes?
[x] Command line build passes?
[x] Has this been smoke tested?
[x] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

[ ] Changes appear to address issue?
[ ] Reviewer has tested changes by following the provided instructions?
[ ] Changes appear not to be breaking changes?
[ ] Appropriate automated tests included?
[ ] Code style and in-line documentation are appropriate?
[ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
[ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi commented 9 months ago

Just needs an issue created / linked to the PR

The issue has been created here: https://github.com/akhenry/openmct-yamcs/issues/434

ozyx commented 9 months ago

Just needs an issue created / linked to the PR

The issue has been created here: #434

Need an issue to resolve for what this PR fixes as it only fixes realtime limits but the issue references staleness and fault management

akhenry / openmct-yamcs

Fix realtime limits #396

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist