refactor: Convert `openmct-yamcs` to ESModule - Githubissues

akhenry / openmct-yamcs

Open MCT YAMCS plugin

14 stars 9 forks source link

refactor: Convert `openmct-yamcs` to ESModule #410

Closed shefalijoshi closed 10 months ago

shefalijoshi commented 10 months ago

Closes #409

Describe your changes:

We need to update openmct-yamcs to match the cjs import syntax for tests.
Also, the tests changed in 3.3.0 and are updated with the new locators.
Added lint step
Added linting rules for ESModule Import
Remove Deploysentinel
Added e2e watch mode to match openmct
Update network tests to inspect the request/response

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

[x] Changes address original issue?
[x] Tests included and/or updated with changes?
[x] Command line build passes?
[x] Has this been smoke tested?
[x] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

[ ] Changes appear to address issue?
[ ] Reviewer has tested changes by following the provided instructions?
[ ] Changes appear not to be breaking changes?
[ ] Appropriate automated tests included?
[ ] Code style and in-line documentation are appropriate?
[ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
[ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi commented 10 months ago

We can't merge this until we know consumers can still import it. I tested this with VIPER and it's totally borked, so likely (possibly?) a webpack configuration or something else we're missing.

OK I'll update with changes after investigation.