search

akhenry / openmct-yamcs

Open MCT YAMCS plugin
13 stars 9 forks source link

[e2e] MDBOverride limit logic is broken #428

Closed unlikelyzero closed 5 months ago

unlikelyzero commented 6 months ago

At the moment, our mdb override limit logic is not clearing the limit values as intended:

https://github.com/akhenry/openmct-yamcs/blob/master/tests/e2e/yamcs/limits.e2e.spec.js#L115-L117

The fix is to use https://docs.yamcs.org/python-yamcs-client/tmtc/client/#yamcs.tmtc.client.ProcessorClient.clear_alarm_ranges

To clear alarm ranges on the given parameter

shefalijoshi commented 6 months ago

@unlikelyzero Is this still a valid issue?

unlikelyzero commented 5 months ago

I haven't had time to test the fix yet

ozyx commented 5 months ago

solved, this was actually catching a bug