akhenry / openmct-yamcs

Open MCT YAMCS plugin
13 stars 9 forks source link

Warn if default alarms are of a different type than a staticAlarm and… #435

Closed shefalijoshi closed 5 months ago

shefalijoshi commented 6 months ago

… allow the app to continue

Closes #430

Describe your changes:

Change to warning if non- staticAlarms are configured, but allow the app to continue loading.

All Submissions:

Author Checklist

Reviewer Checklist

shefalijoshi commented 5 months ago

@akhenry The console warning does not appear with your xtce because there isn't any alarm defined in it. Try adding something like this to your xtce EnumParameterType:

<DefaultAlarm>
  <EnumerationAlarmList>
   <EnumerationAlarm alarmLevel="warning" enumerationLabel="INVALID"/>
  </EnumerationAlarmList>
 </DefaultAlarm>
akhenry commented 5 months ago

@akhenry The console warning does not appear with your xtce because there isn't any alarm defined in it. Try adding something like this to your xtce EnumParameterType:

<DefaultAlarm>
  <EnumerationAlarmList>
   <EnumerationAlarm alarmLevel="warning" enumerationLabel="INVALID"/>
  </EnumerationAlarmList>
 </DefaultAlarm>

Yep, that'd do it. Thanks!