Add formatter for Binary values from YAMCS - Githubissues

akhenry / openmct-yamcs

Open MCT YAMCS plugin

14 stars 9 forks source link

Add formatter for Binary values from YAMCS #438

Closed jvigliotta closed 7 months ago

jvigliotta commented 7 months ago

Closes #436

Describe your changes:

Have added a formatter for binary formats from YAMCS to match what is shown in the YAMCS admin UI.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

[x] Changes address original issue?
[ ] Tests included and/or updated with changes? (follow up: #437)
[x] Command line build passes?
[x] Has this been smoke tested?
[x] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

[x] Changes appear to address issue?
[x] Reviewer has tested changes by following the provided instructions?
[x] Changes appear not to be breaking changes?
[ ] Appropriate automated tests included?
[x] Code style and in-line documentation are appropriate?
[x] Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
[x] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi commented 7 months ago

Smoke tested. The yamcs UI and openmct UI hex values match.

shefalijoshi commented 7 months ago

Please make sure you write tests for this asap.