akhenry / openmct-yamcs

Open MCT YAMCS plugin
13 stars 9 forks source link

Realtime limits changes are not reflected #439

Closed ozyx closed 6 months ago

ozyx commented 6 months ago

Summary

When limits are updated, they aren't reflected in the plot right away and they should be.

Expected vs Current Behavior

When limits are updated for telemetry, the change should reflect immediately in realtime mode.

Impact Check List

Steps to Reproduce

  1. Create an overlay plot with a telemetry endpoint like the timelyParameter
  2. Ensure that some limits are set for this telemetry endpoint (api/mdb-overrides/{yamcs instance}/{processor}/parameters/{full parameter path}) with payload like:
    {
    action: 'SET_DEFAULT_ALARMS',
    defaultAlarm: {
        staticAlarmRange: [
            {
            level: 'WATCH',
            minInclusive: -10,
            maxInclusive: 10
            }
        ]
    }
    }
  3. Enable limits for this overlay plot.
  4. Check that limits are correctly updated when mdb overrides are added or removed in real time.

Environment

Open MCT Version: Open MCT 4.0.0 Deployment Type: dev OS: All Browser: all

Additional Information

ozyx commented 5 months ago

Testathon 3/12/24:

Tested changing mdboverrides live and the plot reacted and updated correctly. I did see an issue where the old limit lines were re-instated after zooming in/out after a mdboverride, but it was fixed by a Reload.

I would call this verified