akhenry / openmct-yamcs

Open MCT YAMCS plugin
14 stars 9 forks source link

Sorting in Events and Command History has serious problems #442

Closed jvigliotta closed 7 months ago

jvigliotta commented 7 months ago

Summary

VIPEROMCT-428 @charlesh88

Sorting requires double-toggle

Interacting with table sorting in the Events and Command History views requires a double-toggle of the column sort method to take effect. This problem does not exist with other scrolling table views such as numeric telemetry.

Sorting not working for some columns

Sorting by a non-time based column like Message or Type just doesn't work. This problem does not exist with other scrolling table views such as numeric telemetry.

Expected vs Current Behavior

Impact Check List

Steps to Reproduce

  1. Load the Events or Command History table view. By default, it will be sorted by Gen Time.
  2. Click another column that would apply a very different sort order (like Message, or Type) and observe: the table's sorting doesn't change.
  3. Clicking the same column again to reverse that sort will now apply that sorting.
  4. Repeating 3. will now apply sorting.
  5. Clicking another column will NOT apply sorting, but should.

    Environment

    • Open MCT Version:
    • Deployment Type:
    • OS:
    • Browser:

Additional Information

Follow up issue for underlying reason created: https://github.com/nasa/openmct/issues/7583

unlikelyzero commented 7 months ago

Testing notes on the viperopenmct issue

ozyx commented 7 months ago

Verified with 1 issue found -- Testathon 3/19/24

When embedded in a Telemetry Table, sorting works perfectly.

If you're trying to sort the static objects themselves however it fails to sort as it requires mutating the configuration of an immutable object and throws an error

akhenry commented 7 months ago

Downgrading to critical and reopening. Sorting now works in most cases, but fails in the table view of immutable objects. Workaround is to create a new Telemetry Table and drag the telemetry point in.

jvigliotta commented 7 months ago

Testing (for new changes)

charlesh88 commented 6 months ago

Testathon 2024-04-25 verified fixed with Events table; no Command history available.

rukmini-bose commented 6 months ago

Verified Testathon 4/25/2024