VIPEROMCT-494: realtime and historical providers should provide same datum format - Githubissues

akhenry / openmct-yamcs

Open MCT YAMCS plugin

13 stars 9 forks source link

VIPEROMCT-494: realtime and historical providers should provide same datum format #444

Closed davetsay closed 5 months ago

davetsay commented 5 months ago

Closes VIPEROMCT-494

Describe your changes:

Do not include id in historical data
Refactor realtime and historical providers to use same datum generator to prevent regression

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

[x] Changes address original issue?
[ ] Tests included and/or updated with changes?
[x] Command line build passes?
[x] Has this been smoke tested?
[x] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

[ ] Changes appear to address issue?
[ ] Reviewer has tested changes by following the provided instructions?
[ ] Changes appear not to be breaking changes?
[ ] Appropriate automated tests included?
[ ] Code style and in-line documentation are appropriate?
[ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
[ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

akhenry commented 5 months ago

Nice! This should have the additional benefit of reducing memory usage.