akhenry / openmct-yamcs

Open MCT YAMCS plugin
13 stars 9 forks source link

Historical Telemetry Provider needs to accept incoming "order" options for requests #454

Closed jvigliotta closed 5 months ago

jvigliotta commented 5 months ago

Summary

Currently telemetry request orders are hardcoded to asc this can lead to situations where the wrong set of limited telemetry is requested. We need to accept incoming order options from views making requests.

Expected vs Current Behavior

We should apply requests based on what views send in. We are hard coding to ascending.

Impact Check List

Steps to Reproduce

  1. Navigate to a telemetry table that has telemetry
  2. Ensure it is in limited mode (toggle at bottom right of telemetry table)
  3. Set time conductor to a large range (1 hr or more)
  4. Hover mouse over pause button
  5. Refresh the browser
  6. Pause as soon as telemetry request is finished (pretty much when pause button becomes visible)
  7. Observe the timestamps for the data is from the beginning of the time range, not the end

Environment

Additional Information

Directly related to: https://github.com/nasa/openmct/issues/7636

jvigliotta commented 5 months ago

Testing

ozyx commented 5 months ago

Verified Fixed-- Testathon 4/4/24

davetsay commented 5 months ago

verified