akhenry / openmct-yamcs

Open MCT YAMCS plugin
14 stars 9 forks source link

chore: bump playwright to 1.45.0 #462

Closed ozyx closed 5 months ago

ozyx commented 5 months ago

Closes

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

unlikelyzero commented 5 months ago

@ozyx these are failing

1) [chromium] › yamcs/filters.e2e.spec.mjs:32:5 › Filter tests @yamcs › Can filter events by severity 

    Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium-1117/chrome-linux/chrome
    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browsers:              ║
    ║                                                                         ║
    ║     npx playwright install                                              ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝
ozyx commented 5 months ago

@ozyx these are failing

1) [chromium] › yamcs/filters.e2e.spec.mjs:32:5 › Filter tests @yamcs › Can filter events by severity 

    Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium-1117/chrome-linux/chrome
    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browsers:              ║
    ║                                                                         ║
    ║     npx playwright install                                              ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝

@unlikelyzero the openmct PR has to go in first, otherwise we get mismatched versions when openmct installs (as the dependency comes from it)

ozyx commented 5 months ago

@unlikelyzero fixed, rdy 4 re-review