search

akheron / jansson

C library for encoding, decoding and manipulating JSON data
http://www.digip.org/jansson/
Other
3.05k stars 809 forks source link

fix #572 #573

Closed tpgxyz closed 3 years ago

tpgxyz commented 3 years ago

use --version-script in case of linkers that does not support --default-symver This is WIP to fix #572

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 96.232% when pulling 3b0c5d1107e4697dc1616eaa939a4b8b3e588b8b on tpgxyz:LLD into 2de2c3d5fc702396a2a5ae8f70ab98a0011d486e on akheron:master.

tpgxyz commented 3 years ago

Looks like your CI test does not use LLVM/lld as linker. I tested this locally with CC=clang and LD=lld and when i ranllvm-readobj --dyn-syms *.so it listed correct list of symbols.

tpgxyz commented 3 years ago

Ok i've make it more simplified. First cmake checks for --default-symver and if test fails it checks for --version-script

tpgxyz commented 3 years ago

@ploxiln ping

akheron commented 3 years ago

Merged, thanks!

tpgxyz commented 3 years ago

@akheron Thanks.