search

akheron / jansson

C library for encoding, decoding and manipulating JSON data
http://www.digip.org/jansson/
Other
3.02k stars 807 forks source link

Remove unused ${SOURCE_DIR}/include include path #646

Closed Bigpet closed 1 year ago

Bigpet commented 1 year ago

The directory ${CMAKE_CURRENT_SOURCE_DIR}/include is never created or used. Except in case of an in-source build but then ${CMAKE_CURRENT_BINARY_DIR}/include would be the same, so it would only duplicate the correct entry.

Not sure if the intermediary JANSSON__INCLUDE_DIRS is still necessary but I thought I'd change as little as possible.

The reason for eliminating this is that when you use CLion and sync into a docker container it will try to copy all include dirs back. Non-existent paths cause warnings every time.

coveralls commented 1 year ago

Coverage Status

Coverage: 96.152% (-0.08%) from 96.231% when pulling e7c9ef8e52aec565530d9e69e81603d690419715 on Bigpet:patch-1 into a22dc95311a79f07b68fdfeefe3b06eb793d3bc9 on akheron:master.

akheron commented 1 year ago

Thanks!