This is a respin of the rejected #461 containing a reimplementation of the
feature in a less intrusive manner for library users keeping it disabled.
The nftables project is very interested in having this feature to provide
similar error reporting to its JSON API users as there is for non-JSON input.
This new implementation does not introduce any overhead on storage and
negligible on CPU cycles if not enabled: It then boils down to a few extra
function calls returning early after a simple variable value check.
The above is realized by storing json_t objects' location data in a hash table
indexed by the object's address. The table is initialized upon first insert,
which then registers a destructor function using atexit() to free up any data
at program exit (to avoid complaints from memory checkers like valgrind).
If an object is deleted, its corresponding hashtable entry is removed along
with it. To facilitate location data for simple values, the singleton 'true',
'false' and 'null' objects have to be turned into allocated data structures (so
they get a unique address in memory).
This MR contains five commits:
is fallout, a previous commit missed to update tests/.gitignore.
adds a function to print a format string with negative test results.
This is a respin of the rejected #461 containing a reimplementation of the feature in a less intrusive manner for library users keeping it disabled.
The nftables project is very interested in having this feature to provide similar error reporting to its JSON API users as there is for non-JSON input.
This new implementation does not introduce any overhead on storage and negligible on CPU cycles if not enabled: It then boils down to a few extra function calls returning early after a simple variable value check.
The above is realized by storing json_t objects' location data in a hash table indexed by the object's address. The table is initialized upon first insert, which then registers a destructor function using atexit() to free up any data at program exit (to avoid complaints from memory checkers like valgrind).
If an object is deleted, its corresponding hashtable entry is removed along with it. To facilitate location data for simple values, the singleton 'true', 'false' and 'null' objects have to be turned into allocated data structures (so they get a unique address in memory).
This MR contains five commits: