Use target-based cmake settings

akheron / jansson

C library for encoding, decoding and manipulating JSON data

http://www.digip.org/jansson/

Other

3.06k stars 815 forks source link

Closed Andrew-Au closed 2 months ago

Andrew-Au commented 1 year ago

Update minimum required to CMake version 3.5 (versions older than 3.5 are deprecated as of 3.27)
update add_definitions to target_compile_definitions
use target_include_directories for public library includes

Andrew-Au commented 1 year ago

resolves #663

akheron commented 2 months ago

Thanks! I'm not an expert in CMake, but if experts say that this is the right way to do it, I'm inclined to believe 😄

Can you clarify why the Jansson::jansson alias is needed?

Andrew-Au commented 2 months ago