akhikhl / multiproject-git-gradle

Gradle script for multi-project git-based setup, configuration and build
30 stars 12 forks source link

Ability for Project name to have a "-" dash, So it can be used in dependencies #16

Closed kavink closed 10 years ago

kavink commented 10 years ago

If a project name has a "-" in it, It cannot be used as a variable in dependencies, as the gradle will not build as fails as it does not like it.

e.g. if git repository and rootProject.name is project-1, then gradle.properties will be project-1_version

and dependencies would be compile "group1:libB:$project-1_version"

The build will fail.

Possible solution would be to automatically replace - with _ or have ability to user specify variable name other than default.

akhikhl commented 10 years ago

The problem is well reproducible. I like your idea of replacing '-' with '_' - it will allow to fix the problem.

kavink commented 10 years ago

Thanks, Ill keep an watch for a fix , so i can test again.

akhikhl commented 10 years ago

Fixed in version 1.0.17. Example setup: https://dl.dropboxusercontent.com/u/15089387/multi-project-setup-dashed-project-name.zip

kavink commented 10 years ago

Awesome!!! :+1: Thanks... let me test it...

kavink commented 10 years ago

Works! Closing it, Fixed in : ef8e3316af793beeb84d0d4897afa9167aad1276