Closed mcmil closed 10 years ago
That's a nice feature! To discuss before merge: maybe, it would be better to rename jvmParameter(s) to jvmArg(s), so that we stay "compatible" with other gradle plugins? I would consider even renaming launchParameters to launchArgs.
Thanks for the fast feedback. I've changed jvmParameters to jvmArgs as you've suggested. I'm not sure about changing launchParameters because it would probably break existing builds. I've also added the feature to the shell build (not only for windows).
Wonderful, thank you so much :)
JVM args can now be passed from the product configuration. This change is needed in order to easily support e(fx)clipse start as an equinox application. The use case would be something like this:
We cannot pass the jvm params using the -vmargs launch parameter, because it is ignored by the osgi runtime when we try to bootstrap it with e(fx)clipse dependencies.