akhilerm / youtube-music-alexa-skill

Alexa skill to play songs from youtube music on echo devices
Apache License 2.0
66 stars 26 forks source link

Stopped working last week #8

Open ORi0N opened 1 month ago

ORi0N commented 1 month ago

Hi @akhilerm, the integration stopped working since last week.

Cooncidently I also received the following mail:

We are reaching out to you to notify you about upcoming changes to AWS Lambda’s recursive loop detection. Recursive loop detection detects and terminates recursive loops between AWS Lambda and other supported services, preventing runaway workloads due to misconfiguration. Recursive loop detection is currently supported for loops between AWS Lambda, Amazon SQS, and Amazon SNS. In 2024, Lambda will be extending recursive loop detection support to Amazon S3. As an incremental step in the full launch of this feature, Lambda will be making underlying changes to how recursive loop detection works. Starting July 8, 2024, recursive invocations that pass through Lambda and S3 where S3 is NOT the event source or trigger to the Lambda function will be detected and terminated after approximately 16 recursive invocations. An example of a recursive loop that will now be terminated is a Lambda function storing data in S3 bucket, which triggers notifications to SNS, which triggers the same Lambda function. This update will be gradually rolled out in June in all commercial regions where recursive loop detection is supported (Recursive loop detection is not currently supported in the following commercial regions: Middle East (UAE), Asia Pacific (Hyderabad), Asia Pacific (Melbourne), Israel (Tel Aviv), Canada West (Calgary), Europe (Spain), and Europe (Zurich)). What action should I take? If you have a function that relies on intentional recursion with Amazon S3, you should contact AWS Support [1] to opt your account out of recursive loop detection to avoid potential disruption of this workload. Please create a support case for each account that requires opt-out and state which region requires the opt-out.

Could this have anything to do with it?

ORi0N commented 1 month ago

I see two relevant errors:

2024-07-16T07:03:38.876Z 2024-07-16T07:03:38.876Z 84a08d2a-4cee-4b95-8046-8bb8d5ecea2f WARN WARNING: ytdl-core is out of date! Update with "npm install ytdl-core@latest".

2024-07-16T07:03:46.720Z 122b5409-0cb1-468c-849c-03e7aaa64876 INFO ~~~~ Error handled: AskSdk.GenericRequestDispatcher Error: Unable to find a suitable request handler. at createAskSdkError (/var/task/node_modules/ask-sdk-runtime/dist/util/AskSdkUtils.js:23:19) at GenericRequestDispatcher.dispatchRequest (/var/task/node_modules/ask-sdk-runtime/dist/dispatcher/GenericRequestDispatcher.js:72:55) at async GenericRequestDispatcher.dispatch (/var/task/node_modules/ask-sdk-runtime/dist/dispatcher/GenericRequestDispatcher.js:45:22) at async CustomSkill.invoke (/var/task/node_modules/ask-sdk-core/dist/skill/CustomSkill.js:68:26)

Any pointer what to try @akhilerm

akhilerm commented 1 month ago

Interesting. I havent received an email like the above and the skill still functions. AFAIU, we are not using an S3 bucket in this skill, so I am not sure if the content of the email and the skill not functioning are related.

Can you raise a PR to update the ytdl-core version, else I can do it in a few days. About the second error, I will have to investigate and see if it can be reproduced from my end.

akhilerm commented 3 weeks ago

@ORi0N Did the skill start working after ytdl was updated ?

ORi0N commented 3 weeks ago

I dont know how to do it?

Op za 3 aug 2024 om 16:06 schreef Akhil Mohan @.***>

@ORi0N https://github.com/ORi0N Did the skill start working after ytdl was updated ?

— Reply to this email directly, view it on GitHub https://github.com/akhilerm/youtube-music-alexa-skill/issues/8#issuecomment-2266722495, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLFXPCSUCSQLBRWBM7LW3ZPTPURAVCNFSM6AAAAABK6ZNTBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWG4ZDENBZGU . You are receiving this because you were mentioned.Message ID: @.***>

akhilerm commented 3 weeks ago

Does the echo device respond with "Sorry I had trouble doing that. Please try again". Or there is no response from the device?

ORi0N commented 3 weeks ago

It says its going to play it, but simply doesnt.

ORi0N commented 1 week ago

So how can i update ytdl?