Closed anandphulwani closed 3 months ago
Hi, thanks for your contribution. I tested this out, but the notes window does not seem to reappear when all windows lose focus, for instance, when using Win+D
. In the current implementation, it regains topmost
window status when such an interaction takes place.
However, the current implementation is flawed in that the notes window regains topmost
status when an untitled window (e.g., a Chromium extension popup) is focused.
Let me know what your thoughts are; thanks for your interest.
Understood, if you want me to rectify this, i can, but i want to leave this out for you, in order to understand the changes better, i am sure you will figure it out.
Earlier, i was facing a lot of issues with flickering, i wasn't able to work at all, were you also facing this issue at your end?
I apologize, i really misread your comment, probably because i was tired from last night, i have made the changes for you to check, it works on "Win+D" now, i have sent new updates to the same branch.
Hi, thanks very much for the contribution, and for the readable code—I wrote the bulk of this code a few years back; it is thus not very organized and uses some questionable conventions.
The implementation works very well—there were some flickering issues (as you mentioned) with the earlier implementation, but this appears to have fixed that.
I would now only ask you to make minor reformatting changes by a) changing function and variable names to use camel case (Python code typically uses underscores, but this code questionably deviates from that) and b) formatting the code using PEP8
guidelines, i.e., just run the file through autopep8
once and re-check for breaking changes.
I will merge the PR after these minor edits.
Thank you once more for your work!
Resolved the
topOrNot
problem, do check and reply. You saidHELP WANTED
, so help comes at your doorstep. :)