akhilkedia / AllTrans

Completely Translate Android apps in-place aka Google translate in Chrome
Other
385 stars 32 forks source link

The module does not work in LSPosed #30

Open Heecama opened 2 years ago

Heecama commented 2 years ago

Enable the system framework in this and only that, but it seems to be that it does not work, is there anything I can do? I would appreciate if you could also explain how to do logs or tell me the information needed to provide it

kylemd commented 2 years ago

You need to enable it for every app that you'd like to translate. Also you may need to enable Experimental Hooks, I had to for Weidian.

akhilkedia commented 2 years ago

Latest release tested on latest LSPosed with android 11, works fine. Please reopen if issue persists.

PeterNjeim commented 2 years ago

Not working for me on LSPosed, enabled for System Framework, Settings Storage, and the apps I want translated. Maybe the reason is due to me using the Zygisk version?

akhilkedia commented 2 years ago

@PeterNjeim I have not tested it with the Zygisk version, but please send me a log following instructions here - https://github.com/akhilkedia/AllTrans#if-you-still-have-problems-like-force-close-or-parts-of-an-app-not-being-translated

PeterNjeim commented 2 years ago

GitHub app Android 11 LSPosed 1.7.1 (6358) - Zygisk logcat_02-04-2022_14-46-36.txt

akhilkedia commented 2 years ago

GitHub app Android 11 LSPosed 1.7.1 (6358) - Zygisk logcat_02-04-2022_14-46-36.txt

Thanks, the logs are very helpful in understanding the issue.

Details of the issue, in case someone is interested -

  1. I use the settings provider as a proxy to get the user's settings for my app.
  2. This android version seems to impose an arguments check on the settings provider. (line 392 of your log file) https://android.googlesource.com/platform/frameworks/base/+/refs/heads/android11-release/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java#2464
  3. Perhaps simply changing the URI I use to fit the regexes allowed here would fix this issue. I will update the app with such a new URI.
oldman20 commented 2 years ago

I have same problem, it working fine in past, now cant work maybe android security update reason? Android Q LSPosed-v1.8.3-6548-zygisk-debug Modules-Logs-LSPosed_2022-05-05T01_28_09.654.zip Verbose-Logs-LSPosed_2022-05-05T01_28_46.765.zip

PeterNjeim commented 2 years ago

Please only comment on issues if you have something to add. The issue has already been verified and a fix has been theorised. The developer will implement this when they please, or if you can make a PR that'd be great too. Please note that GitHub issues are subscriber-based and we would rather not be notified when nothing new has happened.

akhilkedia commented 2 years ago

This issue seems to be unrelated to the previous issue - android fragmentation is hard to deal with..

Details of this issue, in case anyone is interested -

  1. I use settings provider as a proxy to get user's settings as well as on-device translations.
  2. For this, I need some requests to be blocking.
  3. I use android.os.Binder.allowBlockingForCurrentThread() to achieve this, but this version of android seems to either not have such a method, or hides it.

I will try and see if I can figure out a work-around.

I have same problem, it working fine in past, now cant work maybe android security update reason? Android Q LSPosed-v1.8.3-6548-zygisk-debug Modules-Logs-LSPosed_2022-05-05T01_28_09.654.zip Verbose-Logs-LSPosed_2022-05-05T01_28_46.765.zip

oldman20 commented 2 years ago

This issue seems to be unrelated to the previous issue - android fragmentation is hard to deal with..

Details of this issue, in case anyone is interested -

  1. I use settings provider as a proxy to get user's settings as well as on-device translations.
  2. For this, I need some requests to be blocking.
  3. I use android.os.Binder.allowBlockingForCurrentThread() to achieve this, but this version of android seems to either not have such a method, or hides it.

I will try and see if I can figure out a work-around.

I have same problem, it working fine in past, now cant work maybe android security update reason? Android Q LSPosed-v1.8.3-6548-zygisk-debug Modules-Logs-LSPosed_2022-05-05T01_28_09.654.zip Verbose-Logs-LSPosed_2022-05-05T01_28_46.765.zip

Thank all people! But would u provide more detail the 1 method?

oldman20 commented 2 years ago

I solved it by downgraded to v1.9.3, strange