akhilkedia / AllTrans

Completely Translate Android apps in-place aka Google translate in Chrome
Other
385 stars 32 forks source link

Android S (12) compatibility / Twitter compatibility #33

Open nate-moo opened 2 years ago

nate-moo commented 2 years ago

I am having issues with this on Twitter (the only app I need it for) which I'm not sure if it's how Twitter works or if it's a change in Android S

Nothing happens when the app is selected and enabled, enabled agressive mode and still nothing.

More details can be provided if needed. Thanks!

nate-moo commented 2 years ago

Alright I have figured out it's a Twitter thing as discord works

akhilkedia commented 2 years ago

I just verified on Android 11 that for twitter, the UI elements of the app get translated just fine, but the tweets themselves are not translated. Text in embedded previews of links also gets translated. This is probably a bug in my webpage translation logic, in which I am missing some elements. I will try and look into it.

nate-moo commented 2 years ago

any updates? just wondering as this would be immensely helpful for me. thanks

akhilkedia commented 2 years ago

The Javascript translation code i use works when using a browser, but not in the Twitter app, probably due to some idiosyncrasies of webview.

I will have to look more into this, as it is not a simple case of missing some elements. I will update here when it is done.