akhodakivskiy / VimFx

Vim keyboard shortcuts for Firefox
https://addons.mozilla.org/firefox/addon/vimfx
Other
1.41k stars 174 forks source link

Thank you. #892

Open Granjow opened 7 years ago

Granjow commented 7 years ago

@lydell and @akhodakivskiy – today, I had to switch to Vimium due to Firefox 57 (and other great extensions like Tab Groups and Beyond Australis got lost without replacement …).

Thanks for your work on this great extension. It really changed browsing from meh to fun. You are awesome.

lydell commented 7 years ago

Thank you! It really means a lot to hear things like this! :)

mitermayer commented 6 years ago

@lydell @akhodakivskiy interested if you guys have a rough idea on what would be required to allow support for firefox 57+.

I may be willing to contribute to it

lydell commented 6 years ago

@mitermayer See #860. I think it is a better idea to contribute to Saka Key, though. Both projects are MIT licensed, so you can easily copy code from VimFx.

sudoyang commented 6 years ago

This is the best!. Thanks so much!

ahstro commented 6 years ago

Just wanted to add my thanks for VimFX. It was the first keyboard browsing plugin that worked exactly as I wanted it to. πŸ™

ghost commented 6 years ago

After years of dealing with constantly broken pentadactyl/vimperator situations, I switched over to this fantastic extension. It was such a refreshing extension that balanced features and performance. I'm glad to have used it and am sad to see it go. Thanks so much, @lydell.

levinit commented 6 years ago

vimfx is practical.πŸ‘

Nebucatnetzer commented 6 years ago

I agree with all that was said before, VimFX was a really great addon and the first that really worked for me.

jflorian commented 6 years ago

Just want to chime in here as another very satisfied user that had started with pentadactyl then vimperator then a whole slew of others, including vimium before landing here -- it's always the last place you look! This was the first one that I thought was done right all the way through. Like a good friend passing, I wish I'd known it sooner.

I'd like to also mention that new Vim-like extensions are still popping up. I just found vim-vixen but haven't had much time to evaluate it yet. Seems very lean and clean. Might be worth mentioning on the README here.

Nebucatnetzer commented 6 years ago

vim-vixen is quite nice but has the problem that you currently can't black list URLs. Beside that it's IMO the most promising one.

jflorian commented 6 years ago

@Nebucatnetzer , blacklist? You mean like a way to turn off the extension for some sites? Guess I've never used that feature on any of these, despite being a power user. Guess it's just the sites I visit have never necessitated such a need. If anything, I get upset when the key bindings aren't there as I'd expect, such as when looking at the Feedbro main page, which is more like a FF preferences page than a real web site. Like what /proc is to a real filesystem. Don't know what the FF parlance for that is. Virtual page?

bae22 commented 6 years ago

Just wanted to add my thanks to @lydell and @akhodakivskiy for all your work on VimFX. Can't imagine using Firefox without it, and sad to see it go.

Nebucatnetzer commented 6 years ago

@jflorian exactly yes. Sites like Google Docs for example have their own keybindings which then gets a bit hairy if they trigger before the vim plugins.

girst commented 6 years ago

From me too a big thank you to all the contributors and developers, especially @lydell and @akhodakivskiy of course! No other vim-type extension has put this much thought in the f -link-labels -- the most important elements are actually the easiest combination of letters.

Just a FYI: The addon still works in Firefox Developer Edition 57 when you set extensions.legacy.enabled to true. (Same for Nightly 58, so this might be a viable path for the near future)

Turysaz commented 6 years ago

I also just wanted to say thank you. My first vim-style-browsing experience was with Luakit, which has built-in vim-like keybindings. The UX of Luakit was good, but it often just did not feel polished. When I then stumbled upon VimFx, it was like a revelation to me. VimFx has absolutely made my life a bit better. :-) Thanks to all contributors for this great piece of software!

john-soda commented 6 years ago

Was the best add-on ever! Tanks very much! Can somebody could give me an advise, which one of these three add-ons is the closest to vim FX?

ahstro commented 6 years ago

@john-soda I don't know about "closest", but Vimium-FF has served my particular usage well. It does suffer from being a content script, so the page has to be loaded before it can be used, but I assume the others do as well (I don't remember that aspect of them). Saka and Vixen seemed to offer a few more "power user" features though.

sitedyno commented 6 years ago

Thanks to everyone who has contributed to this extension. I found it late so have only been using it 6-8 months, but it's made a huge difference in my FF experience. Thanks so much!

sbseltzer commented 6 years ago

Thank you for this project. Sounds like it's dying now, but the past year of using it has been a blast. Much love to the maintainer and contributors. :)

geniousli commented 6 years ago

Thanks your great work, i have a pleasure time with your production

anthony-geoghegan commented 6 years ago

I've just upgraded to Firefox 57 and while I love the speed, my interaction with the browser UI feels crippled without VimFx (and ItsAllText). I was going to open a Thank you issue but it’s heartening to see that this one has been open since September.

Many thanks to @lydell @akhodakivskiy for providing such an elegant browser extension that has successfully avoided bloat and feature-creep to focus on providing a quality keyboard-based UI.

spacepluk commented 6 years ago

Another big thank you here, VimFX will be sorely missed!

sbseltzer commented 6 years ago

I've been evaluating alternatives and so far the biggest problem I have is the inability to select Firefox menu items and navigate the settings/addons pages. Granted VimFX was slightly buggy with this, but it did a good enough job for me. Does anyone know if this is impossible to implement using the new API, or is contributing the feature to other addons possible?

lydell commented 6 years ago

select Firefox menu items

Not sure what you mean here?

navigate the settings/addons pages

WebExtensions are not allowed to do that.

VimFX was slightly buggy with this

Buggy with what? Just curious πŸ˜‰

sbseltzer commented 6 years ago

Not sure what you mean here?

Whatever the e b command was called. It was nice because several extensions I used didn't have shortcut keys to open their menus, but they did have toolbar icons which could activate/focus their interface when clicked. Being able to "click" them via VimFX was really nice.

Buggy with what? Just curious πŸ˜‰

In that when I opened menu popups from "clicking" toolbar icons as described above, like the Firefox main menu, VimFX would not be available and the menu wouldn't focus. This meant I needed to use my mouse to click or focus on anything in it. This was an occasional pain that I learned to live with. I imagine this was a limitation of the extension API for security reasons, so I suppose "bug" was a misleading word.

A shame that I'll never be able to navigate options menus with keyboard alone. This is going to be a major annoyance for me going forward.

Still, this was a great addon. Hoping the new WebExtensions eventually get extended to support some of these features again.

lydell commented 6 years ago

I miss the eb command too (and, yes, the results did vary when it comes to what clickable things were found and how well they were activated). It is also one of the things that WebExtensions can't do.

girst commented 6 years ago

TIL about eb. I'll add my reminder that VimFX still works on Firefox Developer Editon 58.

@lydell - maybe add that to the README?

lydell commented 6 years ago

@girst You mean the extensions.legacy.enabled pref, that only works in Developer Edition and Nightly? (For how long?) Not sure that's something we should promote. Dedicated users will find it anyway.

girst commented 6 years ago

yep, that's it. People are still looking for ways to work around the legacy addon deprecation. for how long? No guarantees, but I'll guess that most of the APIs VimFX uses will stay around for quite some time (and for me, every day I can use VimFX longer counts).

well, updated from 58b1 to b4 today, and it finally broke. I'll miss this addon :'( works on ff-dev 58b8 again! yay!

pasau commented 6 years ago

-rip- best addon in the history of addons

sbseltzer commented 6 years ago

Yeah, I'm seriously feeling the pain with it today. I've been putting together a Saka Key configuration that mimics it since it seems to be the easiest alternative to retrofit, but it's just not the same... It has a few niceties that VimFX didn't, but it's missing a lot of features that I used on a daily basis. Like the next and previous when searching for text, or a f which was probably my favorite thing besides e b.

Guess some of us are just gonna have to pick an alternative to contribute to and hope things get better. I've never dabbled with extensions before, but it's probably not too hard. Like @lydell suggested, it may be best to extend Saka Key.

jflorian commented 6 years ago

@seltzy I missed it when I first tried Saka Key, maybe because it wasn't yet featured, but it now has a sense of "profiles" I believe is the term used where you can change all of the key bindings at once. IIRC, one choice was to mimic VimFx. I liked the look of the project but was totally turned off by the default bindings and diidn't want to mess around redoing them all. It still won't be VimFx but if you didn't notice this setting it'll be hard to adapt.

My biggest miss with Saka Key at this point is the ability to dictate which search engine I want by a keyword with o or t. IIUC, that's what another extension, just Saka, is supposed to bring when it becomes available.

I tried giving up the whole VIM UI for Firefox and just adapt to the built-in key bindings since those always work regardless of it's a normal page or a built-in one, but the search engine/keyword thing is something I depend on so much. If anyone knows who to do that with the regular address bar in plain old FF, please share.

pasau commented 6 years ago

for some reason vimfx was the only one that worked in about:newtab, about:addons, etc. it's annoying when you Shift+j a couple of tabs and get stuck in a tab where the shortcut won't work and you have to do Control+Tab on this one tab. Also the visual mode was perfect. i went back to vimium-ff and saka, they're not as good. they don't even work at all on addons.mozilla.org; mail.google.com kinda bad too

sbseltzer commented 6 years ago

@jflorian I managed to get a basic profile working, but like you say, it needs some work to feel as smooth. As for o, you can use ctrl+L. Not as nice, but on my keyboard I'm usually using the edge of my palm to hit ctrl so it's only marginally more cumbersome. I'll bet there are other extensions out there you can use to re-map that.

@pasau I know, right? I wonder why they have problems with some websites. Seems like a good candidate for contribution. Probably just a matter of where/when to initialize the extension when the page loads.

jflorian commented 6 years ago

@seltzy I am aware of ctrl-l but not of a way to search using one of my many configured engines, only the default one. With the o command I can enter the search engine's keyword as a prefix. With engines as diverse as one for Python library documentation and another for Wikipedia, well you can imagine how that context helps.

sbseltzer commented 6 years ago

@jflorian Ah I see. I didn't know search engine configuration was a feature of VimFX. I use DuckDuckGo as my default and it has a !bang feature that can serve the same purpose. Not as direct, and it has the limitation of not being configurable on a per-user basis, but still it has served me well.

lydell commented 6 years ago

Saka Key … one choice was to mimic VimFx.

The "VimFx profile" was very recently added to Saka Key, so I'm not sure if it has been released yet: https://github.com/lusakasa/saka-key/pull/98

for some reason vimfx was the only one that worked in about:newtab, about:addons, etc.

There's a very good reason for this: WebExtensions are not allowed to access those tabs. So even if VimFx was updated, not even it could do it.

they don't even work at all on addons.mozilla.org

That's some "security" thing Mozilla copied from Chrome extensions (which are not allowed to run on their addons site).

I didn't know search engine configuration was a feature of VimFX

Because there is none. I'm not sure what you're talking about.

Mark-Eng commented 6 years ago

Just want to add my thanks as well. I'm not a programmer and so had never heard of Vim or Vim-style keybindings before stumbling upon this add-on. Changed my life!

spacepluk commented 6 years ago

Another thing that annoys me about the alternatives is that none of them allow to map <C-n> to switch to the next tab :(

lydell commented 6 years ago

@spacepluk What do you mean? All of them have commands for switching tabs.

spacepluk commented 6 years ago

@lydell oops, bad markdown... I meant you can't map <C-n> (edited above)

jflorian commented 6 years ago

Responding here to my own mention of not knowing how to use FF's address bar to specify which search engine to use. I just discovered, it's no different than Vimium and others. You simply prefix the search with your search engine keyword. So I have gg=Google, yt=YouTube, wp=Wikipedia, etc. which means I can do a Wikipedia search for, say vim with "wp vim". As soon as I type "wp" I see a helpful hint saying "Search with Wikipedia".

sbseltzer commented 6 years ago

@jflorian Yeah no idea what you're talking about. Maybe that's from another extension, or a feature of FF I've never stumbled across.

jflorian commented 6 years ago

@seltzy It's just a built-in feature. Simply go to Preferences > Search and there you'll see One-Click Search Engines. While they work I find adding them cumbersome. It as is if the FF devs are trying to make them mysterious and magical. Vimium has "custom search engines" which are independent but behave much the same way. However, Vimium makes adding more trivial when an engine config is so simple as:

wp: https://www.wikipedia.org/w/index.php?title=Special:Search&search=%s Wikipedia

The %s is the only magic bit; it merely gets replaced with your search terms. So any site that has a search field that results in a URL just for that search is easily made into a "search engine" for FF.

VimFx got this right, like so many other aspects of Vim-ing FF -- let FF do things natively as much as possible. I actually should have realized that VimFx wasn't doing anything special with these engines and then I wouldn't even had to raise my Q earlier regarding this. My brain was tainted though by all the other Vim-ish extensions that did require me to set up search engines independent of FF.

So now I have my answer. I just now need to decide which is better key bindings I don't like but which are consistent everywhere in FF or those that I much prefer but don't work on special pages meaning I kind of need to know two sets. I suspect it'll be the latter because FF simply doesn't offer a way to follow links using the keyboard (that I know of). One hopes that FF will eventually offer WebExtensions to work on any page. IMHO this really should be up to the user. Let me choose if I wish to trust an extension or not rather than blindly assuming it must be evil. Why should I put more trust in FF than a particular extension? (Don't get me wrong, I like being able to prevent some or even most from having such access.)

sbseltzer commented 6 years ago

I recommend lobbying for a more permissive WebExtension API so that a suitable VimFX replacement can be developed. It'd be nice if we could get Mozilla to adopt a smartphone-like permissions model so that you could grant certain extensions access to things like the about:addons tab or browser UI elements. I imagine things could move that way eventually.

I decided to punt and downgrade my home computer FF for now, accepting the risks. I'll keep Quantum on my work computer and explore Saka Key more. If I can make the time I'd like to contribute to it to get my most used features back. At least that way I can transition myself in a less disorienting fashion.

lydell commented 6 years ago

@seltzy The developer of Tridactyl is doing a great job working with Mozilla to come up with more keyboard-y APIs.

sbseltzer commented 6 years ago

@lydell Great to hear! Certainly will be keeping my eye open for that. Do you have a list of requests/reports that have been filed that people can comment on to draw more attention to them?

lydell commented 6 years ago

I think this is the main one: https://bugzilla.mozilla.org/show_bug.cgi?id=1215061

grepsuzette commented 6 years ago

Both Saka and the new vimium are unusable on some pages, including most Mozilla Firefox pages. As soon as the address bar is selected I get stuck there.

I will never ever use Google Chrome again, but until VimFx gets available, which I guess is never happening, I'll stick with palemoon.

lydell commented 6 years ago

@emugel WebExtensions are not allowed to run in about: pages as well as on addons.mozilla.org. There's currently no for WebExtensions way to focus the location bar, and as soon as you focus anything outside the current webpage WebExtensions are not able to run commands anymore. So even if VimFx was updated, it wouldn't help.