search

akhodakivskiy / VimFx

Vim keyboard shortcuts for Firefox
https://addons.mozilla.org/firefox/addon/vimfx
Other
1.42k stars 174 forks source link

'gX' Open the Recently Closed Tabs menu not working properly on VimFx v0.24.5 #966

Closed Ok-pass closed 2 years ago

Ok-pass commented 2 years ago

Hello, thank you for the great extension. OS: ArchLinux Browser: Mozilla Firefox 96.0.2 Legacyfox: 2.3 VimFx v0.24.5 Noticed that Open the Recently Closed Tabs menu does not open a menu, instead just creates a blank space at the top of the browser. 2

It correctly recognizes when there aren't any closed tabs and send the No recently closed tabs notification, so I'm guessing the problem is with the popup injection itself.

Tested on Waterfox Classic 2022.01 on the same system where it's working without issues.

girst commented 2 years ago

mozregression: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29bdbbe89264b91d1bd4205c45536c9222a8d6ee&tochange=257f2c96cef502a1d674df56c8e39d76d8ed4d89

girst commented 2 years ago

thank you for the report! that was quite an interesting search through the pushlog :)

fix released in v0.24.6

girst commented 2 years ago

Tested on Waterfox Classic 2022.01 on the same system where it's working without issues.

@Ok-pass: which vimfx version did you test this with? the recent versions of vimfx should require at least firefox 68, iirc.

Ok-pass commented 2 years ago

Thank you for the fix.

which vimfx version did you test this with? the recent versions of vimfx should require at least firefox 68, iirc.

My bad, I forgot to mention I'm using VimFx 0.20.15 on Waterfox.