search

akhoury / nodebb-plugin-emailer-mandrill

An emailer plugin for NodeBB using Mandrill as a third party service
MIT License
3 stars 11 forks source link

Bounce email renders incorrectly #19

Closed djensen47 closed 8 years ago

djensen47 commented 8 years ago

The bounce email is being rendered as follows:

Hello,

bounce.generic

I do have the default language on my forums set to en_US

julianlam commented 8 years ago

Can you let me know the version of NodeBB you're running?

djensen47 commented 8 years ago

0.9.3

julianlam commented 8 years ago

Fixed in v0.3.5

djensen47 commented 8 years ago

I'm still seeing the issue. Is there something that I need to do?

julianlam commented 8 years ago

After updating the plugin, you'll need to execute a full restart of NodeBB.

djensen47 commented 8 years ago

I've done that. :confused:

I restarted again but I still see the same email response.

djensen47 commented 8 years ago

I tried creating a new topic, got a new email notification, and responded with an unregistered email address and I'm still getting the following:

Hello,

bounce.generic

I would re-open the issue but it appears that I cannot.

julianlam commented 8 years ago

Odd, what is your setup again? Can you output the contents of plugin.json for this module?

djensen47 commented 8 years ago

NodeBB 0.9.3 using MongoDB. I've set the default language of the forums to en_US.

plugin.json

{
    "id": "nodebb-plugin-emailer-mandrill",
    "name": "Emailer (Mandrill)",
    "description": "Mandrill Emailer for NodeBB",
    "url": "https://github.com/akhoury/nodebb-plugin-emailer-mandrill",
    "library": "./index.js",
    "templates": "templates",
    "hooks": [
        { "hook": "filter:email.send", "method": "send"},
        { "hook": "filter:admin.header.build", "method": "admin.menu"},
        { "hook": "static:app.load", "method": "init" }
    ],
    "languages": "languages",
    "defaultLang": "en_GB"
}

The plugin admin page shows that I am indeed running version 0.3.5 of the emailer-mandrill plugin.

julianlam commented 8 years ago

How did you restart? Perhaps try a full stop of NodeBB and start...

djensen47 commented 8 years ago

From yesterday (it may not have been clear) …

I've done that. :confused:

I restarted again but I still see the same email response.

I have done a complete restart several times. I've also started in both developer mode and regular.

djensen47 commented 8 years ago

It looks like it is a bug in NodeBB.

In the ACP > General > Language I changed from en_US to en_GB and it started working. The defaultLang setting appears to no be working?

djensen47 commented 8 years ago

Should I file an issue against NodeBB?