akhoury / nodebb-plugin-spam-be-gone

yup
MIT License
24 stars 25 forks source link

Add automatic HAM (false positive) reporting based on user rep #45

Closed lots0logs closed 8 years ago

lots0logs commented 8 years ago

@akhoury Let me know if you see any issues. I was in a hurry when I wrote it :grimacing:

akhoury commented 8 years ago

@lots0logs thanks for this, but the diff is really hard to see with the all the spaces/tabbing changes.

lots0logs commented 8 years ago

These are the commits that have the important changes:

I can split this up if you want, but I can't do it until tonight (I'm working all day). Sorry!

julianlam commented 8 years ago

Just a note: We don't enforce coding style on plugins, even if they're bundled in with every NodeBB install. :smile:

If you guys order four spaces, all the power to you.

lots0logs commented 8 years ago

Well personally, I prefer tabs but that wasn't why I did it here (its not my plugin after all!). The .editorconfig file in this repo calls for tabs so that's why I did it. @akhoury Let me know if you prefer spaces, I can revert that part of the PR when I get home from work tonight. Cheers!

akhoury commented 8 years ago

.editorconfig file in this repo calls for tabs so that's why I did it

oops my bad

Let me know if you prefer spaces

nah, i don't care, as long as we're consistent. Thanks for sharing the important commits, they look good.