Closed lots0logs closed 8 years ago
@lots0logs thanks for this, but the diff is really hard to see with the all the spaces/tabbing changes.
These are the commits that have the important changes:
I can split this up if you want, but I can't do it until tonight (I'm working all day). Sorry!
Just a note: We don't enforce coding style on plugins, even if they're bundled in with every NodeBB install. :smile:
If you guys order four spaces, all the power to you.
Well personally, I prefer tabs but that wasn't why I did it here (its not my plugin after all!). The .editorconfig
file in this repo calls for tabs so that's why I did it. @akhoury Let me know if you prefer spaces, I can revert that part of the PR when I get home from work tonight. Cheers!
.editorconfig
file in this repo calls for tabs so that's why I did it
oops my bad
Let me know if you prefer spaces
nah, i don't care, as long as we're consistent. Thanks for sharing the important commits, they look good.
@akhoury Let me know if you see any issues. I was in a hurry when I wrote it :grimacing: