search

aki017 / slack-ruby-gem

A Ruby wrapper for the Slack API
MIT License
242 stars 79 forks source link

Only update api if specifes the name #44

Open mgi166 opened 8 years ago

mgi166 commented 8 years ago

The reason why I create this PR

Recently, updates https://github.com/aki017/slack-api-docs/commit/1ac07b4a9902bb1386d46ddaf484e754c6290429 by aki017/slack-api-docs-generator.

But aki017/slack-ruby-gem does not follow the latest aki017/slack-api-docs. So if you execute rake api:update, creates too many diffs in one commit.

It's undesirable to revert api update if you failed.

I think that if rake api:update specifies api name, only update the api, so prevent the tragedy and you can more easily update aki017/slack-ruby-gem in stages

I hope that aki017/slack-ruby-gem follows latest slack api as soon as possible.

Usage

# No specifies the argument, update all.
$ rake api:update

# Specifies the api name, only updates the api.
$ rake 'api:update[channels]'

What do I ask

What do you think this policy? Please let me oponion.

miguelperez commented 5 years ago

This seems reasonable. @aki017 are you planning on updating the gem with the latest Slack API calls?