Closed mackwic closed 9 years ago
ping :up: :smile:
Happy new year ! :tada: :smile:
Any feedback on the PR ? I can change it however you want, just say it. ;)
Oh ! I didn't saw your last commits. I guess I can close this PR, thought I would have liked at least a comment on your side.
Please, next time say that you are already working on it. The new code is great, better than mine without any doubt, but it's more courteous to explain to the people wanting to contribute that they can use their time to something else. There's no shame in that.
Also, thanks to have addressed the points I made about the version. :+1:
@mackwic Sorry for my long silence :sob: your code looks great! but i released new version include big change, so plz check it :bow: sorry
Changes:
As the gem works well, I bumped the version to 1.0. I hope you don't mind this jump. ;)