Update the API at the date of today (commit date)

aki017 / slack-ruby-gem

A Ruby wrapper for the Slack API

MIT License

242 stars 79 forks source link

Update the API at the date of today (commit date) #5

Closed mackwic closed 9 years ago

mackwic commented 9 years ago

Changes:

Update all the method with https://api.slack.com/methods at the date of today
BREAKING CHANGE: methods are now defined in the Client class rather than use the hacky #missing_method
Provide a testing utility (needs to add a slack token)
Fix gem dependency (rake was missing)

As the gem works well, I bumped the version to 1.0. I hope you don't mind this jump. ;)

mackwic commented 9 years ago

ping :up: :smile:

mackwic commented 9 years ago

Happy new year ! :tada: :smile:

Any feedback on the PR ? I can change it however you want, just say it. ;)

mackwic commented 9 years ago

Oh ! I didn't saw your last commits. I guess I can close this PR, thought I would have liked at least a comment on your side.

Please, next time say that you are already working on it. The new code is great, better than mine without any doubt, but it's more courteous to explain to the people wanting to contribute that they can use their time to something else. There's no shame in that.

Also, thanks to have addressed the points I made about the version. :+1:

aki017 commented 9 years ago

@mackwic Sorry for my long silence :sob: your code looks great! but i released new version include big change, so plz check it :bow: sorry みさわ