search

aki2o / emacs-plsense

Provide omni completion for Perl.
29 stars 4 forks source link

Provide an enable function instead of modifying hooks unconditionally #2

Closed purcell closed 10 years ago

purcell commented 11 years ago

(Related to https://github.com/milkypostman/melpa/pull/1019)

It's considered somewhat bad practice to unconditionally modify hooks in other packages: this small change makes that step explicit.

-Steve

aki2o commented 10 years ago

I think If user install this extension and write (require 'plsense), it means user enable this extension. So, an enable function is not need.

But, as you say, it's not good to unconditionally modify behavior in other packages. So, I updated plsense.el and added setting such as you done in this pull request. Would you please see plsense.el line about 455?

purcell commented 10 years ago

Looks good!