Plugin fails to load on beta release (1.37.0)

styx commented 5 years ago

[Enter steps to reproduce:]

On Atom start

Atom: 1.37.0-beta0 x64, 1.37.0-beta1 x64 Electron: 2.0.18 OS: Mac OS X 10.14.3 Thrown From: Atom Core

Stack Trace

Uncaught Error: ::set with a 'source' and no 'sourceSelector' is not yet implemented!

At /Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:11

Error: ::set with a 'source' and no 'sourceSelector' is not yet implemented!
    at Config.set (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:11:330629)
    at SettingsFile.activate (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:6114)
    at SettingsFile.load (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:11:3425225)
    at l.readFile (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:5992)
    at /Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:11:581165
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)

Commands

Non-Core Packages

atom-beautify 0.33.4 
atom-change-case-menu 0.2.0 
atom-jest-snippets 2.1.0 
atom-lcov 2.0.0 
autoclose-html 0.23.0 
build 0.70.0 
busy 0.7.0 
busy-signal 2.0.1 
clipboard-plus 0.5.1 
cucumber-step 0.2.0 
cursor-history 0.13.2 
double-tag 1.7.0 
editorconfig 2.4.0 
egghead-react-snippets 1.2.2 
erb-snippets 1.1.0 
es6-javascript 1.0.0 
ex-mode 0.18.0 
expand-region 0.4.2 
file-icons 2.1.31 
git-blame 1.8.0 
git-plus 8.6.2 
go-debug 1.6.2 
go-expanderr 0.1.1 
go-find-references 1.2.3 
go-imports 0.2.0 
go-plus 6.1.0 
go-quick-import 0.3.1 
go-rename 0.3.0 
go-signature-statusbar 1.2.3 
haskell-grammar 0.4.0 
highlight-selected 0.16.0 
hyperclick 0.1.5 
intentions 1.1.5 
jump-to-import 3.6.5 
jumpy 5.0.2 
language-actionscript 0.2.0 
language-arduino 0.4.3 
language-babel 2.85.0 
language-docker 1.1.8 
language-elixir 0.22.1 
language-gherkin 1.0.4 
language-haml 0.32.1 
language-nginx 0.8.0 
language-ocaml 1.9.5 
language-powershell 5.0.0 
language-thrift 1.0.2 
language-x86asm 0.9.0 
last-cursor-position 0.9.3 
line-ending-converter 1.3.2 
linter 2.3.0 
linter-csslint 2.0.5 
linter-docker 0.3.2 
linter-eslint 8.5.3 
linter-flow 5.6.1 
linter-golinter 1.3.0 
linter-gotype 1.0.0 
linter-govet 1.0.0 
linter-ruby 1.3.0 
linter-ui-default 1.7.1 
nuclide 0.366.0 
open-git-modified-files 0.2.4 
open-this 0.5.0 
pigments 0.40.2 
prettier-atom 0.56.4 
pretty-json 2.1.1 
ruby-block-converter 4.1.1 
ruby-syntax-replacer 0.5.1 
teletype 0.13.3 
todo-show 2.3.2 
toggle-quotes 1.1.3 
vim-mode-clipboard-plus 0.3.0 
vim-mode-plus 1.36.0 
vim-mode-plus-move-selected-text 0.12.0 
you-complete-me 0.8.1

Here is original issue I posted to Atom Core https://github.com/atom/atom/issues/19144

caleb531 commented 5 years ago

I'm experiencing this same issue, same error as above.

aki77 commented 5 years ago

I will check this weekend.

caleb531 commented 5 years ago

I've confirmed that the code triggering this error is the '*' syntax in settings/expand-region.cson. Removing that block, or changing * to something alphanumeric, resolves the error.

@aki77, do you have any insight into this?

aki77 commented 5 years ago

Thanks for the detailed report. I will try to move the global default settings to the following location.

https://github.com/aki77/atom-expand-region/blob/master/lib/main.coffee#L11

caleb531 commented 5 years ago

@aki77 I can confirm v0.5.0 fixes the error completely. Everything is working again. Thanks so much!

aki77 / atom-expand-region