search

aki77 / simplecov-report-action

A GitHub Action that report simplecov coverage.
MIT License
39 stars 21 forks source link

last_run.json not found with v1.5.0 #27

Closed anit closed 2 years ago

anit commented 2 years ago

The new version 1.5.0 has changed node version of this package from 12 to 16 and it seems to be the root cause of an error we have been facing:

Error: Cannot find module '/home/runner/work/orgapp/orgapp/coverage/.last_run.json'
Require stack:
- /home/runner/work/_actions/aki77/simplecov-report-action/v1/dist/index.js

This is the version of Github action that was downloaded to us: 

Download action repository 'aki77/simplecov-report-action@v[1](https://github.com/****/****/runs/70378****?check_suite_focus=true#step:16:1)' (SHA:a06b28c81eb8254618c93eebd09956767373b07e)
aki77 commented 2 years ago

If set aki77/simplecov-report-action@v1.4.1 will it succeed?

anit commented 2 years ago

@aki77 Yes. It did. We pinned it to 1.4.1 and our actions are running fine now.

aki77 commented 2 years ago

@anit

It does not seem to reproduce in my environment. Can you provide a minimal reproduction repository?

anit commented 2 years ago

@aki77 There you go: Failed build with v1.5.0: https://github.com/anit/rails-github-actions-example/runs/7039382108?check_suite_focus=true Success build with v1.4.1: https://github.com/anit/rails-github-actions-example/runs/7039441928?check_suite_focus=true

aki77 commented 2 years ago

I have checked with minimal settings and it seems to succeed.

https://github.com/aki77/rails-github-actions-example/actions/runs/2558418038

https://github.com/aki77/rails-github-actions-example/commit/3c0526556d4a97ce77bf9075ca01b806f9962a2c

aki77 commented 2 years ago

This is due to the absence of coverage/.last_run.json. Please review the simplecov configuration.

In v1.4.1, the entire process is skipped because it is unsupported except for PR events.