akielaries / openGPMP

Hardware Accelerated General Purpose Mathematics Package
https://akielaries.github.io/openGPMP/
MIT License
8 stars 3 forks source link

OOP Refactoring #107

Open akielaries opened 4 months ago

akielaries commented 4 months ago

Most of the codebase is OOP in the sense that there are often many methods shoved into 1 class and 1 class per file which violates some common paradigms.

gpmp::linalg::sigproc::lpf(SIGNAL, FREQ, CUTOFF) for a standalone function OR gpmp::linalg::sigproc::LPF() for a class

there might not be enough to expand into a complex class with a few member variables and methods

akielaries commented 4 months ago

Signal processing methods have been removed but this point still stands for some class. For example the gpmp::linalg::Mtx class doesn't feature any OOP methods. I can't think of any benefits in doing so since these functions purpose is pretty much a 1 off.