Closed sidsbrmnn closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
00cff83
) 88.11% compared to head (cef6c40
) 88.11%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request fixes hanging test cases on macOS during build time.
Issue
compute_miller_rabin()
expects two arguments:d
andn
, whered
is an odd number andn
is the target number to be checked.d
is generated bymiller_rabin_prime()
and the boundaries forn
are handled inmiller_rabin_prime()
. These boundaries are not handled bycompute_miller_rabin()
as it expects the inputn
to be greater than 4.Changes Made
compute_miller_rabin()
to accept only the target numberd
generation tocompute_miller_rabin()
compute_miller_rabin()
and fix the expected outcome forcompute_miller_rabin(1)
to false, since 1 is not a prime numberOne auxiliary change was necessary to successfully build openMTPK.
sigmoid_activ
andsigmoid_deriv
were incorrectly passed as the compiler recognized them as static functions and not member functionsTesting Done
The changes are tested on macOS 13.3 running on M2.
Fixes #27