akihiko122 / swfobject

Automatically exported from code.google.com/p/swfobject
0 stars 0 forks source link

WMODE for Express Installer #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. WMODE is not being set for the express installer. This is interfering
with our site's dropdown navigation as a WMODE of transparent or opaque is
required for overlapping HTML elements to render on top of Flash.
2. Edit the swfobject code so that the express installer inherits the WMODE
of the original SWF.
3. When the object node is written to the DOM it gets a param element as a
child node with WMODE == 'transparent'
4. When the express installer is written to the DOM with the WMODE set the
buttons become unclickable.

What is the expected output? What do you see instead?
Expected: Express Installer SWF with clickable buttons and a WMODE of
'transparent'
Actual: Express Installer SWF with unclickable buttons and a WMODE of
'transparent'

What version of the product are you using? On what operating system?
swfobject 2.1 (with minor modification for WMODE on express installer) |
Windows XP | Firefox.

Please provide any additional information below.

Code Changes:

function showExpressInstall(regObj) {
...
    // edit - pass wmode to createSwf for expressInstaller
    createSWF({ data:regObj.expressInstall, id:EXPRESS_INSTALL_ID,
width:regObj.width, height:regObj.height }, { flashvars:fv,
wmode:regObj.wmode }, replaceId);

...
}

embedSWF: function(...){
...
    var regObj = {};
    regObj.id = regObj.altContentId = replaceElemIdStr;
    regObj.width = widthStr;
    regObj.height = heightStr;
    regObj.expressInstall = xiSwfUrlStr;
    // begin edit
    if(parObj && typeof parObj.wmode != UNDEF){
        regObj.wmode = parObj.wmode;
    }else{
        regObj.wmode = "opaque"
    }
    // end edit
    showExpressInstall(regObj);
...
}

Original issue reported on code.google.com by mgallagh...@gmail.com on 28 Jul 2008 at 7:08

GoogleCodeExporter commented 9 years ago
Thanks for the feedback, we will investigate in which other parameters and 
attributes
 express install should inherit.

Original comment by bobbyvandersluis on 29 Jul 2008 at 8:41

GoogleCodeExporter commented 9 years ago

Original comment by bobbyvandersluis on 29 Jul 2008 at 8:41

GoogleCodeExporter commented 9 years ago
Related issues:

http://code.google.com/p/swfobject/issues/detail?id=139 -> inherit 
allowScriptAccess
to set the correct security settings

http://code.google.com/p/swfobject/issues/detail?id=127 -> inherit flashvars to
enable customized actions in case of fail or cancel

also can be handy:
- class attribute -> to inherit style rules
- parameters that define layout like: scale, align, salign and bgcolor

Original comment by bobbyvandersluis on 30 Jul 2008 at 9:48

GoogleCodeExporter commented 9 years ago
From SWFObject 2.2 alpha 9 onwards Express Install inherits all parameters and
attributes from the targeted SWF

Original comment by bobbyvandersluis on 5 Jan 2009 at 4:39

GoogleCodeExporter commented 9 years ago
Included in the SWFObject 2.2 beta1 release

Original comment by bobbyvandersluis on 16 Apr 2009 at 3:05